fix(babel-preset): preserve Platform.select initializers - #58350
Closed
mfkrause wants to merge 1 commit into
Closed
Conversation
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
the
Shared with Meta
|
@vzaidman has imported this pull request. If you are a Meta employee, you can view this in D119065685. |
|
This pull request has been reverted by 679a7b7. |
shashikant-panchal
pushed a commit
to shashikant-panchal/react-native
that referenced
this pull request
Sep 10, 2026
Summary:
The React Native Babel preset replaces `Platform.select({...})` with the selected property during production transforms. JavaScript evaluates every object property initializer before calling `Platform.select`, so this can silently remove side effects from non-selected properties.
For example:
```js
Platform.select({
ios: selected(),
android: discarded(),
});
```
JavaScript would run both side effects, `selected()` and `discarded()`. The plugin's current behavior removes `discarded` on iOS however.
This fix preserves both side effects by testing for purity.
## Changelog:
[GENERAL] [FIXED] - Preserve side effects from discarded Platform.select property initializers in the Babel preset.
Pull Request resolved: react#58350
Test Plan: Added a regression test and ran existing tests, linter and formatter.
Reviewed By: GijsWeterings
Differential Revision: D119065685
Pulled By: vzaidman
fbshipit-source-id: ca209fe9b728990019e9da478670cc3bdb4cd6e2
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The React Native Babel preset replaces
Platform.select({...})with the selected property during production transforms. JavaScript evaluates every object property initializer before callingPlatform.select, so this can silently remove side effects from non-selected properties.For example:
JavaScript would run both side effects,
selected()anddiscarded(). The plugin's current behavior removesdiscardedon iOS however.This fix preserves both side effects by testing for purity.
Changelog:
[GENERAL] [FIXED] - Preserve side effects from discarded Platform.select property initializers in the Babel preset.
Test Plan:
Added a regression test and ran existing tests, linter and formatter.